fix: Adapt URLs generated in the backend to new routes #6649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
luka-nextcloud,
grnd-alt and
elzody
as code owners
juliusknorr
force-pushed
the
fix/redirect-no-rewrite
branch
from
11af64c to
fb1bac0
Compare
|
@juliusknorr Code change looks ok but could you check cypress and unit tests? |
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
fix/redirect-no-rewrite
branch
2 times, most recently
from
c3e9bde to
67315aa
Compare
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
fix/redirect-no-rewrite
branch
from
67315aa to
1177d08
Compare
…cases Signed-off-by: Julius Knorr <[email protected]>
|
Cypress catched a bug that resulted in an endless recursion, fixed with my last commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue reported by @peterwebdesign that links in activity emails or the activity stream may not work as they were always generated with index.php and the vue router redirect did not work properly with legacy hash based urls.
Besides fixing the hash detection to redirect from
#/board/123to/board/123this also adapt all cases where old URLs were still generated.